release-24.3: roachprod/roachtest/logictest: unconditionally disable Sentry crash reporting #146558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eporting Previously, the environment variable, `COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1` was used to disable both telemetry and crash reporting. However, the default for `diagnostics.reporting.enabled` has flipped from `false` to `true` as of [1]. The same PR added a regression wrt to the environment variable–it no longer disabled crash reporting via Sentry. Recall, we prefer to disable Sentry crash reporting for _all_ tests since our (internal) test artifacts contain a superset of contextual information; i.e., Sentry reports are of limited use for test failures; as such they add more noise than signal. Also recall, unit tests effectively disable Sentry by not invoking `cli.doMain`, which invokes `SetupCrashReporter`. Both integration (docker) and roachtests rely on `COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1`. Mixedversion logic tests until this change, simply assumed that `diagnostics.reporting.enabled` defaulted to `false`. This change fixes the regression, introduced in [1], by correctly updating `diagnostics.reporting.enabled` to affect the environment variable. It also sets `COCKROACH_CRASH_REPORTS` to the empty string, which disables crash reporting _before_ a server is fully initialized. [1] #131097 Fixes: #145457 Epic: none Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.3-146343
branch
from
8a6d812 to
08cf813
Compare
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
requested review from
angles-n-daemons
and removed request for
a team
blathers-crl
bot
requested review from
Abhinav1299,
aa-joshi and
arjunmahishi
and removed request for
a team
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
requested review from
DarrylWong,
RaduBerinde,
herkolategan,
srosenberg and
yuzefovich
blathers-crl
bot
added
the
backport
Author
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
DarrylWong
approved these changes
May 12, 2025
Member
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #146343 on behalf of @srosenberg.
Previously, the environment variable,
COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1was used to disable both telemetry and crash reporting. However, the default fordiagnostics.reporting.enabledhas flipped fromfalsetotrueas of [1]. The same PR added a regression wrt to the environment variable–it no longer disabled crash reporting via Sentry.Recall, we prefer to disable Sentry crash reporting for all tests since our (internal) test artifacts contain a superset of contextual information; i.e., Sentry reports are of limited use for test failures; as such they add more noise than signal.
Also recall, unit tests effectively disable Sentry by not invoking
cli.doMain, which invokesSetupCrashReporter. Both integration (docker) and roachtests rely onCOCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1. Mixedversion logic tests until this change, simply assumed thatdiagnostics.reporting.enableddefaulted tofalse.This change fixes the regression, introduced in [1], by correctly updating
diagnostics.reporting.enabledto affect the environment variable. It also setsCOCKROACH_CRASH_REPORTSto the empty string, which disables crash reporting before a server is fully initialized.[1] #131097
Fixes: #145457
Epic: none
Release note: None
Release justification: test-only change